[Cashtab][Alias] Remove redundant node error translation in handleAliasRegistrationError
ClosedPublic
Actions

Authored by emack on Oct 13 2023, 04:59.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC38455aff4a7f: [Cashtab][Alias] Remove redundant node error translation in…

Summary

T3316

The 'too many unconfirmed ancestors' node error is no longer applicable in handleAliasRegistrationError, hence removing the error translation logic.

Test Plan

Attempt to register a new alias on a wallet with insifficient funds and ensure the node error is rendered as a UI pop up
grep -r handleAliasRegistrationError src/

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Oct 13 2023, 04:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2023, 04:59

emack requested review of this revision.Oct 13 2023, 04:59

Harbormaster completed remote builds in B25348: Diff 42666.Oct 13 2023, 05:00

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

@bot build-cashtab

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

In D14638#328766, @emack wrote:

Was a transient failure, I restarted the build and it's green

There was no test for this ?

In D14638#328769, @Fabien wrote:

There was no test for this ?

This is in that same category a few months ago where internal functions (e.g. registerAlias in this case) in a React component (a rendering class) can't be accessed directly. You can only test the initial state and props upon initialization but cases where we need to trigger a custom event (server outage) and then verify its reaction to that event is a challenge with how unit tests are currently set up in Cashtab.

This is mitigated by:

manual test above to observe the error message pop up in the frontend
grep -r handleAliasRegistrationError src/ to ensure no dependency on this removed function from anywhere else in Cashtab

emack edited the test plan for this revision. (Show Details)Oct 13 2023, 09:51

bytesofman accepted this revision.Oct 13 2023, 17:18

This revision is now accepted and ready to land.Oct 13 2023, 17:18

Closed by commit rABC38455aff4a7f: [Cashtab][Alias] Remove redundant node error translation in… (authored by emack). · Explain WhyOct 14 2023, 12:11

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC38455aff4a7f: [Cashtab][Alias] Remove redundant node error translation in….