Differential D14891

thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex
ClosedPublic
Actions

Authored by PiRK on Dec 1 2023, 13:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC86fc2d0d845d: thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex

Summary

This is a partial backport of core#24931
https://github.com/bitcoin/bitcoin/pull/24931/commits/f24bd45b37e1b2d19e5a053dbfefa30306c1d41a
https://github.com/bitcoin/bitcoin/pull/24931/commits/be6aa72f9f8d50b6b5b19b319a74abe7ab4099ff
Depends on D14890

Test Plan

After D14894:

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25791
Build 51162: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 51161: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 1 2023, 13:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2023, 13:11

teamcity edited the summary of this revision. (Show Details)Dec 1 2023, 13:11

PiRK added a child revision: D14892: propagate negative thread safety annotations for avalanche code.Dec 1 2023, 13:13

PiRK published this revision for review.Dec 1 2023, 13:19

PiRK edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B25791: Diff 43346.Dec 1 2023, 13:31

Fabien accepted this revision.Dec 1 2023, 19:58

This revision is now accepted and ready to land.Dec 1 2023, 19:58

Closed by commit rABC86fc2d0d845d: thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyDec 4 2023, 06:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC86fc2d0d845d: thread safety annotation for m_tx_relay_mutex and m_cached_tip_mutex.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

2 lines

qt/

clientmodel.cpp

3 lines

Diff 43346

View Options

src/net_processing.cpp