Paths

Table of Contentst

Differential D14893

sync.h: Add GlobalMutex type
ClosedPublic
Actions

Authored by PiRK on Dec 1 2023, 13:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4d473df4beef: sync.h: Add GlobalMutex type

Summary

And convert global Mutexes to GlobalMutexes:

-BEGIN VERIFY SCRIPT-
sed -i -E -e '/^([a-z]+ )?Mutex [a-z]/ s/Mutex/GlobalMutex/' $(git grep -lE '^([a-z]+ )?Mutex [a-z]')
-END VERIFY SCRIPT-

This is a partial backport of core#24931
https://github.com/bitcoin/bitcoin/pull/24931/commits/a559509a0b8cade27199740212d7b589f71a0e3b
https://github.com/bitcoin/bitcoin/pull/24931/commits/d2852917eecad6ab422a7b2c9892d351a7f0cc96

Depends on D14892

Test Plan

cmake .. -GNinja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja all check-all`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 1 2023, 13:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2023, 13:14

teamcity edited the summary of this revision. (Show Details)Dec 1 2023, 13:14

comment layout

PiRK added a child revision: D14894: sync.h: Imply negative assertions when calling LOCK.Dec 1 2023, 13:19

PiRK mentioned this in D14892: propagate negative thread safety annotations for avalanche code.Dec 1 2023, 13:19

PiRK published this revision for review.Dec 1 2023, 13:24

Harbormaster completed remote builds in B25793: Diff 43348.Dec 1 2023, 13:44

Harbormaster completed remote builds in B25794: Diff 43349.Dec 1 2023, 13:47

Not cs_main ?

In D14893#334432, @Fabien wrote:

Not cs_main ?

That's a RecursiveMutex. But they are treated the same way as GlobalMutex in D14894: LOCKS_EXCLUDED, just check that it is not taken twice in the same scope.

Fabien accepted this revision.Dec 3 2023, 11:19

This revision is now accepted and ready to land.Dec 3 2023, 11:19

Closed by commit rABC4d473df4beef: sync.h: Add GlobalMutex type (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyDec 4 2023, 06:56

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4d473df4beef: sync.h: Add GlobalMutex type.

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

2 lines

2 lines

rpc/

2 lines

4 lines

17 lines

2 lines

util/

system.cpp

2 lines

validation.h

2 lines

validation.cpp

2 lines

wallet/

sqlite.cpp

2 lines

wallet.cpp

4 lines

warnings.cpp

2 lines

Diff 43374

View Options

src/init.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/netbase.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/server.cpp

View Options

src/sync.h

View Options

src/timedata.cpp

View Options

src/util/system.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/wallet/sqlite.cpp

View Options

src/wallet/wallet.cpp

View Options

sync.h: Add GlobalMutex typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43374

src/init.cpp

src/net.h

src/net.cpp

src/netbase.cpp

src/rpc/blockchain.cpp

src/rpc/server.cpp

src/sync.h

src/timedata.cpp

src/util/system.cpp

src/validation.h

src/validation.cpp

src/wallet/sqlite.cpp

src/wallet/wallet.cpp

src/warnings.cpp

sync.h: Add GlobalMutex type
ClosedPublic
Actions

Revision Contents
Changeset List