Reduce bandwidth during initial headers sync when a block is found
ClosedPublic
Actions

Authored by PiRK on Dec 5 2023, 15:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC18cd183b8688: Reduce bandwidth during initial headers sync when a block is found

Summary

If our headers chain is behind on startup, then if a block is found we'll try
to catch up from all peers announcing the block, in addition to our initial
headers-sync peer. This commit changes behavior so that in this situation,
we'll choose at most one peer announcing a block to additionally sync headers
from.

This is a backport of core#25720

Depends on D14913

Test Plan

ninja all check-all

I also successfully ran the new functional test 50 times to reduce the risks of introducing a flaky test.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr25720

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25833
Build 51246: Build Diff	build-debug · build-clang · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-diff
Build 51245: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 5 2023, 15:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2023, 15:16

teamcity edited the summary of this revision. (Show Details)Dec 5 2023, 15:16

PiRK edited the test plan for this revision. (Show Details)Dec 5 2023, 15:17

PiRK added inline comments.Dec 5 2023, 15:22

src/net_processing.cpp
4510 ↗	(On Diff #43407)	Note that currently `m_chainman.GetMutex()` and `cs_main` are the same lock. In the future this could change if the chainstate manager gets its own lock. Here we need the lock for both `m_chainman.ActiveChain()` and for `State(pfrom.GetId())`, so use `cs_main` to be sure we won't loose the lock for `State` in the future. If the lock for `ActiveChain()` changes we will need to correct it in many places anyway, so we are unlikely to miss this one.