Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING9c6f4b94b4a1: Remove blockFinished from BlockAssembler
rABC9c6f4b94b4a1: Remove blockFinished from BlockAssembler

Summary

As per title, stop using spooky action at a distance

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

more-miner-nits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2932
Build 3968: Bitcoin ABC Buildbot (legacy)
Build 3967: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 25 2018, 01:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 01:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a parent revision: D1590: Couple of code nits in miner.cpp.Jul 25 2018, 01:13

Fix accidentally removed code during rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2929: Diff 4388!Jul 25 2018, 01:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2930: Diff 4389!Jul 25 2018, 01:20

Remove a missed reference

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jul 25 2018, 02:03

This revision is now accepted and ready to land.Jul 25 2018, 02:03

Remove wild semicolon

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Reword TestForBlockResult parameter to make it clearer

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2931: Diff 4390!Jul 25 2018, 02:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2932: Diff 4392!Jul 25 2018, 02:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2933: Diff 4393!Jul 25 2018, 02:57

deadalnix requested changes to this revision.Jul 25 2018, 14:30

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/miner.cpp
302 ↗	(On Diff #4393)	You should move this in the header.
643 ↗	(On Diff #4393)	This clearly changes the semantic. You tested for a specific package to be added, but then never adds it. Also, if `blockFinished` is true, the thing continue to loop until iterator runs out.

This revision now requires changes to proceed.Jul 25 2018, 14:30

Fix nits

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Address some more feedback

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jul 25 2018, 15:21

deadalnix added inline comments.

src/miner.h
128 ↗	(On Diff #4402)	You can probably declare this as a private local class in BlockAssembler, as the only function using it is private anyway.
130 ↗	(On Diff #4402)	TXCantFit ?