Page MenuHomePhabricator
Differential D15294

[Cashtab] Better fb logo in social
ClosedPublic
Actions

Authored by bytesofman on Jan 26 2024, 13:05.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCf134cbc22b63: [Cashtab] Better fb logo in social
Summary

Use current fb logo and not antd version. Update styles to support.

Test Plan

npm start and social icons look ok, hover is good

Diff Detail

Repository
rABC Bitcoin ABC
Branch
better-fb-logo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26681
Build 52930: Build Diffcashtab-tests
Build 52929: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 26 2024, 13:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2024, 13:05
bytesofman published this revision for review.Jan 26 2024, 13:06
Harbormaster completed remote builds in B26673: Diff 44617.Jan 26 2024, 13:08
bytesofman updated this revision to Diff 44627.Jan 26 2024, 14:27

version bump

emack requested changes to this revision.Jan 26 2024, 14:39
emack added a subscriber: emack.

Icons and hover looks good - just needs vertical alignment between X and the fb/gh icons.

image.png (72×222 px, 3 KB)

This revision now requires changes to proceed.Jan 26 2024, 14:39
bytesofman updated this revision to Diff 44629.Jan 26 2024, 14:52

all elements same height

bytesofman added a comment.Jan 26 2024, 14:53

image.png (404×964 px, 14 KB)

Harbormaster completed remote builds in B26681: Diff 44627.Jan 26 2024, 14:54
Harbormaster completed remote builds in B26683: Diff 44629.Jan 26 2024, 14:56
emack accepted this revision.Jan 27 2024, 01:04
This revision is now accepted and ready to land.Jan 27 2024, 01:04
Closed by commit rABCf134cbc22b63: [Cashtab] Better fb logo in social (authored by bytesofman). · Explain WhyJan 27 2024, 13:42
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf134cbc22b63: [Cashtab] Better fb logo in social.

Revision Contents
Changeset List

PathSize
cashtab/
2 lines
src/
assets/
1 line
components/
Common/
27 lines

Diff 44627

View Options

cashtab/package.json

Loading...
View Options

cashtab/src/assets/Facebook_Logo.svg

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...