Refactor script_tests.cpp to separate signature generation from PushSig
ClosedPublic
Actions

Authored by deadalnix on Aug 3 2018, 17:02.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6699fc37db52: Refactor script_tests.cpp to separate signature generation from PushSig
rABC6699fc37db52: Refactor script_tests.cpp to separate signature generation from PushSig

Summary

It'll allow for addition of test for OP_CHECKDATASIG .

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

scripttestnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3012
Build 4117: Bitcoin ABC Buildbot (legacy)
Build 4116: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 3 2018, 17:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 3 2018, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3008: Diff 4485.Aug 3 2018, 17:47

Ping?

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1621: Implement OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY.Aug 4 2018, 13:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3012: Diff 4492!Aug 4 2018, 14:33

jasonbcox accepted this revision.Aug 5 2018, 16:14

This revision is now accepted and ready to land.Aug 5 2018, 16:14

Closed by commit rABC6699fc37db52: Refactor script_tests.cpp to separate signature generation from PushSig (authored by deadalnix). · Explain WhyAug 5 2018, 19:16

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

script_tests.cpp

39 lines

Diff 4492

View Options

Refactor script_tests.cpp to separate signature generation from PushSigClosedPublicActions