Page MenuHomePhabricator
Differential D1623

Make push only mandatory when magnetic anomaly activates.
ClosedPublic
Actions

Authored by deadalnix on Aug 5 2018, 15:44.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4714cd362256: Make push only mandatory when magnetic anomaly activates.
rABC4714cd362256: Make push only mandatory when magnetic anomaly activates.
Summary

As per title.

Depends on D1622 and D1611

Test Plan

Added test cases in abc-magnetic-anomaly-activation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 5 2018, 15:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2018, 15:44
teamcity added a subscriber: teamcity.Aug 5 2018, 15:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 5 2018, 16:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3017: Diff 4497.Aug 5 2018, 16:28
jasonbcox requested changes to this revision.Aug 5 2018, 16:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/abc-magnetic-anomaly-activation.py
58 ↗(On Diff #4497)

putting the import within the function definition looks very odd to me. any reason to not put it with the other imports at the top of the file?

This revision now requires changes to proceed.Aug 5 2018, 16:33
deadalnix updated this revision to Diff 4504.Aug 5 2018, 19:22

rebase

teamcity added a comment.Aug 5 2018, 19:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Aug 5 2018, 20:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3020: Diff 4504.Aug 5 2018, 20:02
deadalnix added a child revision: D1625: Add activation code for OP_CHECKDATASIG.Aug 5 2018, 20:55
jasonbcox requested changes to this revision.Aug 6 2018, 19:28

Please clarify the import thing. I want to make sure this isn't my misunderstanding of something Python-specific. Basing my understanding on similar arguments made in the accepted answer here: https://stackoverflow.com/questions/3095071/in-python-what-happens-when-you-import-inside-of-a-function

This revision now requires changes to proceed.Aug 6 2018, 19:28
jasonbcox accepted this revision.Aug 6 2018, 19:43
jasonbcox added inline comments.
test/functional/abc-magnetic-anomaly-activation.py
58 ↗(On Diff #4497)

Talked offline. Since this is only used once, importing here reduces scope of time.

This revision is now accepted and ready to land.Aug 6 2018, 19:43
Closed by commit rABC4714cd362256: Make push only mandatory when magnetic anomaly activates. (authored by deadalnix). · Explain WhyAug 6 2018, 19:44
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
functional/
40 lines

Diff 4516

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-magnetic-anomaly-activation.py

Loading...