Page MenuHomePhabricator

Make push only mandatory when magnetic anomaly activates.
ClosedPublic

Authored by deadalnix on Aug 5 2018, 15:44.

Details

Summary

As per title.

Depends on D1622 and D1611

Test Plan

Added test cases in abc-magnetic-anomaly-activation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Aug 5 2018, 15:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2018, 15:44
jasonbcox requested changes to this revision.Aug 5 2018, 16:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/abc-magnetic-anomaly-activation.py
58 ↗(On Diff #4497)

putting the import within the function definition looks very odd to me. any reason to not put it with the other imports at the top of the file?

This revision now requires changes to proceed.Aug 5 2018, 16:33
jasonbcox requested changes to this revision.Aug 6 2018, 19:28

Please clarify the import thing. I want to make sure this isn't my misunderstanding of something Python-specific. Basing my understanding on similar arguments made in the accepted answer here: https://stackoverflow.com/questions/3095071/in-python-what-happens-when-you-import-inside-of-a-function

This revision now requires changes to proceed.Aug 6 2018, 19:28
jasonbcox accepted this revision.Aug 6 2018, 19:43
jasonbcox added inline comments.
test/functional/abc-magnetic-anomaly-activation.py
58 ↗(On Diff #4497)

Talked offline. Since this is only used once, importing here reduces scope of time.

This revision is now accepted and ready to land.Aug 6 2018, 19:43
This revision was automatically updated to reflect the committed changes.