Page MenuHomePhabricator

Pass flags down to GetSigOpCount

Authored by deadalnix on Jul 26 2018, 00:31.



This will ensure we can use flags to tweak the way sigops are counted in the future. This is necessary for the activation of OP_CHECKDATASIG.

Test Plan

Added test cases to ensure behavior changes as expected when the P2SH flags is flipped.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

deadalnix retitled this revision from Pass filags down to GetSigOpCount to Pass flags down to GetSigOpCount.Jul 26 2018, 01:18
This revision is now accepted and ready to land.Jul 27 2018, 17:20
schancel requested changes to this revision.Jul 27 2018, 17:23
schancel added a subscriber: schancel.
schancel added inline comments.
381 ↗(On Diff #4433)

Why is this passed in? Why doesn't this count the SigOps from the current CScript also?

382 ↗(On Diff #4433)

Do we need a ScriptFlags type? Also why is this being added now?

This revision now requires changes to proceed.Jul 27 2018, 17:23
This revision is now accepted and ready to land.Jul 29 2018, 19:35
This revision was automatically updated to reflect the committed changes.