Differential D15511

[Chronik] Fix one coinbase height in `chronik_spent_by.py` test
ClosedPublic
Actions

Authored by tobias_ruck on Feb 21 2024, 20:21.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC88aa2f430aea: [Chronik] Fix one coinbase height in `chronik_spent_by.py` test

Summary

The coinbase height is not verified in heights before 500, so this test isn't failing, but the correct height would be 102, not 101.

Test Plan

double check the height is correct

Diff Detail

Repository

rABC Bitcoin ABC

Branch

regtest-height-not-enforced

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27307
Build 54177: Build Diff	build-debug · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 54176: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Feb 21 2024, 20:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2024, 20:21

Harbormaster completed remote builds in B27307: Diff 45462.Feb 21 2024, 20:40

actually fix it

tobias_ruck published this revision for review.Feb 24 2024, 16:29

tobias_ruck retitled this revision from Regtest coinbase height seems unenforced sometimes to [Chronik] Fix one coinbase height in `chronik_spent_by.py` test.

tobias_ruck edited the summary of this revision. (Show Details)

tobias_ruck edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B27391: Diff 45569.Feb 24 2024, 16:51

PiRK accepted this revision.Feb 24 2024, 18:08

This revision is now accepted and ready to land.Feb 24 2024, 18:08

Closed by commit rABC88aa2f430aea: [Chronik] Fix one coinbase height in `chronik_spent_by.py` test (authored by tobias_ruck). · Explain WhyFeb 25 2024, 14:52

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC88aa2f430aea: [Chronik] Fix one coinbase height in `chronik_spent_by.py` test.