Page MenuHomePhabricator
Differential D15801

[e.cash] Remove Governance item from core-tech page
ClosedPublic
Actions

Authored by Mengerian on Mar 28 2024, 19:05.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb0fc2d830f26: [e.cash] Remove Governance item from core-tech page
Test Plan

Ran it locally, looks good

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-move-governance
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28139
Build 55823: Build Diff
Build 55822: arc lint + arc unit

Event Timeline

Mengerian created this revision.Mar 28 2024, 19:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2024, 19:05
Mengerian requested review of this revision.Mar 28 2024, 19:05
Harbormaster completed remote builds in B28125: Diff 46552.Mar 28 2024, 19:05
Mengerian updated this revision to Diff 46553.Mar 28 2024, 19:14

Also move imprt at top of file

Harbormaster completed remote builds in B28126: Diff 46553.Mar 28 2024, 19:14
Fabien added a subscriber: Fabien.Mar 28 2024, 19:58
Fabien added inline comments.
web/e.cash/pages/core-tech.js
15 ↗(On Diff #46553)

Why this change ? To match the ordering of the content ?

bytesofman requested changes to this revision.Mar 28 2024, 20:03
This revision now requires changes to proceed.Mar 28 2024, 20:03
Mengerian added inline comments.Mar 28 2024, 20:50
web/e.cash/pages/core-tech.js
15 ↗(On Diff #46553)

Yes, but I can just as easily leave as-is if you prefer

Mengerian updated this revision to Diff 46563.Mar 28 2024, 22:59

Return import to where it was originally

Harbormaster completed remote builds in B28135: Diff 46563.Mar 28 2024, 23:00
bytesofman requested changes to this revision.Mar 28 2024, 23:59
bytesofman added inline comments.
web/e.cash/pages/core-tech.js
210 ↗(On Diff #46563)

imo still an improvement to simply lose this block

This revision now requires changes to proceed.Mar 28 2024, 23:59
bytesofman added inline comments.Mar 29 2024, 00:00
web/e.cash/pages/core-tech.js
210–222 ↗(On Diff #46563)

e.g.

Mengerian updated this revision to Diff 46568.Mar 29 2024, 02:25
Mengerian retitled this revision from [e.cash] Move Governance item lower on core-tech page to [e.cash] Remove Governance item from core-tech page.
Mengerian edited the summary of this revision. (Show Details)

Rather than moving it, just remove it

Harbormaster completed remote builds in B28139: Diff 46568.Mar 29 2024, 02:25
bytesofman accepted this revision.Mar 29 2024, 02:29
This revision is now accepted and ready to land.Mar 29 2024, 02:29
Closed by commit rABCb0fc2d830f26: [e.cash] Remove Governance item from core-tech page (authored by Mengerian). · Explain WhyMar 29 2024, 02:33
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCb0fc2d830f26: [e.cash] Remove Governance item from core-tech page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
14 lines
public/
animations/

Diff 46568

View Options

web/e.cash/pages/core-tech.js

Loading...
View Options

web/e.cash/public/animations/govern.json

Loading...