Page MenuHomePhabricator

[e.cash] Remove Governance item from core-tech page
ClosedPublic

Authored by Mengerian on Mar 28 2024, 19:05.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb0fc2d830f26: [e.cash] Remove Governance item from core-tech page
Test Plan

Ran it locally, looks good

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-move-governance
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28139
Build 55823: Build Diff
Build 55822: arc lint + arc unit

Event Timeline

Also move imprt at top of file

Fabien added inline comments.
web/e.cash/pages/core-tech.js
15 ↗(On Diff #46553)

Why this change ? To match the ordering of the content ?

This revision now requires changes to proceed.Mar 28 2024, 20:03
web/e.cash/pages/core-tech.js
15 ↗(On Diff #46553)

Yes, but I can just as easily leave as-is if you prefer

Return import to where it was originally

bytesofman added inline comments.
web/e.cash/pages/core-tech.js
210 ↗(On Diff #46563)

imo still an improvement to simply lose this block

This revision now requires changes to proceed.Mar 28 2024, 23:59
web/e.cash/pages/core-tech.js
210–222 ↗(On Diff #46563)

e.g.

Mengerian retitled this revision from [e.cash] Move Governance item lower on core-tech page to [e.cash] Remove Governance item from core-tech page.
Mengerian edited the summary of this revision. (Show Details)

Rather than moving it, just remove it

This revision is now accepted and ready to land.Mar 29 2024, 02:29