Paths

Table of Contentst

[ecash-lib] Add `SigHashType`
ClosedPublic
Actions

Authored by tobias_ruck on Apr 11 2024, 23:51.

Details

Reviewers

bytesofman
PiRK

Group Reviewers

Restricted Project

Commits

rABC37fd74385bc0: [ecash-lib] Add `SigHashType`

Summary

SigHashType is a class that represents all possible sighash types that can be used to sign a tx input, for both legacy (before UAHF) and BIP143 signatures.

Test Plan

npm run test && npm run build

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-lib-sighashtype

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28504
Build 56549: Build Diff	ecash-lib-tests
Build 56548: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Apr 11 2024, 23:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 11 2024, 23:51

remove unnecessary imports

Harbormaster completed remote builds in B28502: Diff 47065.Apr 11 2024, 23:53

Harbormaster completed remote builds in B28504: Diff 47067.

tobias_ruck added a child revision: D15956: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`.Apr 12 2024, 01:33

Note that the BIP143 naming is not used in the c++ code, the FORKID name is used instead. That got me confused for a while.

Screenshot from 2024-04-14 09-19-47.png (506×681 px, 74 KB)

This revision is now accepted and ready to land.Apr 14 2024, 07:20

bytesofman accepted this revision.Apr 16 2024, 12:19

camel case sigHashType

Harbormaster completed remote builds in B28608: Diff 47216.Apr 16 2024, 23:01

Closed by commit rABC37fd74385bc0: [ecash-lib] Add `SigHashType` (authored by tobias_ruck). · Explain WhyApr 16 2024, 23:03

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC37fd74385bc0: [ecash-lib] Add `SigHashType`.

Revision Contents
Changeset List

Path

Size

modules/

ecash-lib/

src/

sighashtype.test.ts

86 lines

sighashtype.ts

170 lines

Diff 47067

View Options

modules/ecash-lib/src/sighashtype.test.ts