src/rpc/mining.cpp
299	Should be `Amount nAmount = request.params[2].get_int64() * SATOSHI;`
src/rpc/server.cpp
127	`Amount amt = n * SATOSHI;`
src/validation.cpp
5376	Should be `Amount amountdelta = nFeeDelta * SATOSHI;`

This revision now requires changes to proceed.Sep 4 2018, 17:49

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3188: Diff 4754.Sep 4 2018, 18:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Sep 4 2018, 21:25

This revision now requires changes to proceed.Sep 4 2018, 21:25

COnstruct via = rather than constructor call.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3198: Diff 4769.Sep 5 2018, 12:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1723: Make the constructor taking satoshi as parameter from the Amount class private.Sep 5 2018, 14:28

jasonbcox accepted this revision.Sep 5 2018, 16:41

This revision is now accepted and ready to land.Sep 5 2018, 16:41

Closed by commit rABC8d0f26774d42: Remove various calls to the Amount constructor taking satoshi as argument (authored by deadalnix). · Explain WhySep 5 2018, 18:35

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

4 lines

2 lines

2 lines

2 lines

8 lines

2 lines

6 lines

policy/

fees.cpp

9 lines

primitives/

transaction.cpp

2 lines

qt/

coincontroldialog.cpp

6 lines

sendcoinsdialog.cpp

4 lines

rpc/

2 lines

2 lines

8 lines

2 lines

14 lines

wallet/

rpcwallet.cpp

2 lines

wallet.cpp

50 lines

walletdb.cpp

2 lines

Diff 4742

View Options

src/bitcoin-tx.cpp

View Options

src/coins.cpp

View Options

src/compressor.cpp

View Options

src/feerate.cpp

View Options

src/init.cpp

View Options

src/miner.cpp

View Options

src/net_processing.cpp

View Options

src/policy/fees.cpp

View Options

src/primitives/transaction.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/server.cpp

View Options

src/txmempool.cpp

View Options

src/utilmoneystr.cpp

View Options

src/validation.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.cpp

View Options

Remove various calls to the Amount constructor taking satoshi as argumentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4742

src/bitcoin-tx.cpp

src/coins.cpp

src/compressor.cpp

src/feerate.cpp

src/init.cpp

src/miner.cpp

src/net_processing.cpp

src/policy/fees.cpp

src/primitives/transaction.cpp

src/qt/coincontroldialog.cpp

src/qt/sendcoinsdialog.cpp

src/rpc/mining.cpp

src/rpc/server.cpp

src/txmempool.cpp

src/utilmoneystr.cpp

src/validation.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

Remove various calls to the Amount constructor taking satoshi as argument
ClosedPublic
Actions

Revision Contents
Changeset List