Page MenuHomePhabricator
Differential D1712

Remove various calls to the Amount constructor taking satoshi as argument
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 16:00.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING8d0f26774d42: Remove various calls to the Amount constructor taking satoshi as argument
rABC8d0f26774d42: Remove various calls to the Amount constructor taking satoshi as argument
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 4 2018, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 16:00
teamcity added a subscriber: teamcity.Sep 4 2018, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 4 2018, 16:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3182: Diff 4742.Sep 4 2018, 16:36
jasonbcox requested changes to this revision.Sep 4 2018, 17:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/mining.cpp
299 ↗(On Diff #4742)

Should be Amount nAmount = request.params[2].get_int64() * SATOSHI;

src/rpc/server.cpp
127 ↗(On Diff #4742)

Amount amt = n * SATOSHI;

src/validation.cpp
5376 ↗(On Diff #4742)

Should be Amount amountdelta = nFeeDelta * SATOSHI;

This revision now requires changes to proceed.Sep 4 2018, 17:49
deadalnix updated this revision to Diff 4754.Sep 4 2018, 17:55

rebase

teamcity added a comment.Sep 4 2018, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3188: Diff 4754.Sep 4 2018, 18:47
teamcity added a comment.Sep 4 2018, 18:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Sep 4 2018, 21:25
This revision now requires changes to proceed.Sep 4 2018, 21:25
deadalnix updated this revision to Diff 4769.Sep 5 2018, 12:15

COnstruct via = rather than constructor call.

teamcity added a comment.Sep 5 2018, 12:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3198: Diff 4769.Sep 5 2018, 12:54
teamcity added a comment.Sep 5 2018, 12:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1723: Make the constructor taking satoshi as parameter from the Amount class private.Sep 5 2018, 14:28
jasonbcox accepted this revision.Sep 5 2018, 16:41
This revision is now accepted and ready to land.Sep 5 2018, 16:41
Closed by commit rABC8d0f26774d42: Remove various calls to the Amount constructor taking satoshi as argument (authored by deadalnix). · Explain WhySep 5 2018, 18:35
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
2 lines
2 lines
2 lines
8 lines
2 lines
6 lines
policy/
9 lines
primitives/
2 lines
qt/
6 lines
4 lines
rpc/
2 lines
2 lines
8 lines
2 lines
14 lines
wallet/
2 lines
50 lines
2 lines

Diff 4773

View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/coins.cpp

Loading...
View Options

src/compressor.cpp

Loading...
View Options

src/feerate.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/policy/fees.cpp

Loading...
View Options

src/primitives/transaction.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/utilmoneystr.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...