Page MenuHomePhabricator
Differential D16144

refactor: Use move semantics in `CCheckQueue::Add`
ClosedPublic
Actions

Authored by PiRK on May 13 2024, 06:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdc6291bb0c0f: refactor: Use move semantics in `CCheckQueue::Add`
Summary

refactor: Use move semantics in CCheckQueue::Add

Co-authored-by: Martin Leitner-Ankerl <martin.ankerl@gmail.com>

refactor: Make move semantics explicit for callers

clang-tidy, test: Fix bugprone-use-after-move in Correct_Queue_range()

This is a partial backport of core#26749
https://github.com/bitcoin/bitcoin/pull/26749/commits/6c2d5972f3544c4f3e987828a99e88f27b62cf87
https://github.com/bitcoin/bitcoin/pull/26749/commits/04831fee6dca3eb86cd1d6b9ef879b296263fe35
https://github.com/bitcoin/bitcoin/pull/26749/commits/9a0b5241396efe3b3ceb3931717c30bb94f99bfb

Depends on D16143

Test Plan

ninja all check-all bitcoin-fuzzers bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
13 lines
test/
25 lines
fuzz/
6 lines
2 lines
2 lines

Diff 47748

View Options

src/bench/checkqueue.cpp

Loading...
View Options

src/checkqueue.h

Loading...
View Options

src/test/checkqueue_tests.cpp

Loading...
View Options

src/test/fuzz/checkqueue.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...