Paths

Table of Contentst

Differential D16177

Call ReallocateCache() on each Flush()
ClosedPublic
Actions

Authored by PiRK on May 16 2024, 14:39.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4b916c68bdc2: Call ReallocateCache() on each Flush()

Summary

This frees up all associated memory with the map, not only the nodes.
This is necessary in preparation for using the PoolAllocator for
CCoinsMap, which does not actually free any memory on clear().

This is a partial backport of core#25325
https://github.com/bitcoin/bitcoin/pull/25325/commits/5e4ac5abf54f8e6d6330df0c73119aa0cca4c103

Depends on D16176

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29031
Build 57598: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57597: arc lint + arc unit

Event Timeline

PiRK created this revision.May 16 2024, 14:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 16 2024, 14:39

teamcity edited the summary of this revision. (Show Details)May 16 2024, 14:39

PiRK added a child revision: D16178: Use PoolAllocator for CCoinsMap.May 16 2024, 14:40

Harbormaster completed remote builds in B29031: Diff 47820.May 16 2024, 15:05

PiRK published this revision for review.May 17 2024, 17:29

Fabien accepted this revision.May 20 2024, 08:19

This revision is now accepted and ready to land.May 20 2024, 08:19

Closed by commit rABC4b916c68bdc2: Call ReallocateCache() on each Flush() (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>, committed by PiRK). · Explain WhyMay 20 2024, 15:46

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4b916c68bdc2: Call ReallocateCache() on each Flush().

Revision Contents
Changeset List

Path

Size

src/

9 lines

test/

validation_flush_tests.cpp

6 lines

1 line

Diff 47820

src/coins.cpp

Loading...

src/test/validation_flush_tests.cpp

Loading...

src/validation.cpp

Loading...