Page MenuHomePhabricator
Differential D16212

[cmake] define STRERROR_R_CHAR_P
ClosedPublic
Actions

Authored by PiRK on May 23 2024, 14:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb44d125a8154: [cmake] define STRERROR_R_CHAR_P
Summary

This var is used in sock.cpp (syserror.cpp after D16209) to pick the correct flavor of strerror_r but is never defined.
Define it.

This solution is based on https://github.com/hebasto/bitcoin/pull/6

Test Plan
cmake .. -GNinja
ninja

Check the var is set in build/CMakeCache.txt and build/src/config/bitcoin-config.h

Diff Detail

Event Timeline

PiRK created this revision.May 23 2024, 14:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2024, 14:53
PiRK requested review of this revision.May 23 2024, 14:53
PiRK retitled this revision from define STRERROR_R_CHAR_P to [cmake] define STRERROR_R_CHAR_P.May 23 2024, 14:58
Harbormaster completed remote builds in B29109: Diff 47927.May 23 2024, 15:11
PiRK added a child revision: D16209: util: Replace non-threadsafe strerror.May 23 2024, 15:13
Fabien accepted this revision.May 23 2024, 17:10
This revision is now accepted and ready to land.May 23 2024, 17:10
Closed by commit rABCb44d125a8154: [cmake] define STRERROR_R_CHAR_P (authored by PiRK). · Explain WhyMay 23 2024, 19:11
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb44d125a8154: [cmake] define STRERROR_R_CHAR_P.

Revision Contents
Changeset List

PathSize
src/
config/
9 lines
3 lines

Diff 47927

View Options

src/config/CMakeLists.txt

Loading...
View Options

src/config/bitcoin-config.h.cmake.in

Loading...