Page MenuHomePhabricator
Differential D16217

refactor: Move system from util to common library
ClosedPublic
Actions

Authored by PiRK on May 23 2024, 15:41.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC204370d2ee5b: refactor: Move system from util to common library
Summary

Since the kernel library no longer depends on the system file, move it
to the common library instead in accordance to the diagram in
doc/design/libraries.md.

This is a move-only commit.

This concludes backport of core#27636
https://github.com/bitcoin/bitcoin/pull/27636/commits/7d3b35004b039f2bd606bb46a540de7babdbc41e
Depends on D16216

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.May 23 2024, 15:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2024, 15:41
PiRK requested review of this revision.May 23 2024, 15:41
teamcity edited the summary of this revision. (Show Details)May 23 2024, 15:41
Harbormaster completed remote builds in B29117: Diff 47935.May 23 2024, 16:39
Fabien accepted this revision.May 24 2024, 13:04
This revision is now accepted and ready to land.May 24 2024, 13:04
Fabien added a comment.May 24 2024, 13:04

@bot build-chronik

teamcity awarded a token.May 24 2024, 13:05
Closed by commit rABC204370d2ee5b: refactor: Move system from util to common library (authored by PiRK). · Explain WhyMay 24 2024, 15:33
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC204370d2ee5b: refactor: Move system from util to common library.
PiRK added a comment.May 28 2024, 18:16

@bot build-tsan

teamcity updated a token.May 28 2024, 18:16
teamcity added a comment.May 28 2024, 18:29
Build Bitcoin ABC Diffs / Diff Testing (build-tsan) failed.

Tail of the build log:

chronik_disallow_prune.py                  | ○ Skipped | 0 s
chronik_lokad_id_group.py                  | ○ Skipped | 0 s
chronik_mempool_conflicts.py               | ○ Skipped | 0 s
chronik_pause.py                           | ○ Skipped | 0 s
chronik_plugins_setup.py                   | ○ Skipped | 0 s
chronik_raw_tx.py                          | ○ Skipped | 0 s
chronik_resync.py                          | ○ Skipped | 0 s
chronik_script_confirmed_txs.py            | ○ Skipped | 0 s
chronik_script_history.py                  | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
chronik_script_utxos.py                    | ○ Skipped | 0 s
chronik_serve.py                           | ○ Skipped | 0 s
chronik_spent_by.py                        | ○ Skipped | 0 s
chronik_token_alp.py                       | ○ Skipped | 0 s
chronik_token_broadcast_txs.py             | ○ Skipped | 0 s
chronik_token_burn.py                      | ○ Skipped | 0 s
chronik_token_id_group.py                  | ○ Skipped | 0 s
chronik_token_parse_failure.py             | ○ Skipped | 0 s
chronik_token_script_group.py              | ○ Skipped | 0 s
chronik_token_slp_fungible.py              | ○ Skipped | 0 s
chronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
chronik_token_slp_nft1.py                  | ○ Skipped | 0 s
chronik_tx.py                              | ○ Skipped | 0 s
chronik_tx_removal_order.py                | ○ Skipped | 0 s
chronik_ws.py                              | ○ Skipped | 0 s
chronik_ws_ordering.py                     | ○ Skipped | 0 s
chronik_ws_ping.py                         | ○ Skipped | 0 s
chronik_ws_script.py                       | ○ Skipped | 0 s
feature_bind_port_discover.py              | ○ Skipped | 0 s
feature_bind_port_externalip.py            | ○ Skipped | 0 s
interface_usdt_net.py                      | ○ Skipped | 0 s
interface_usdt_utxocache.py                | ○ Skipped | 0 s
interface_usdt_validation.py               | ○ Skipped | 0 s

ALL                                        | ✓ Passed  | 3144 s (accumulated) 
Runtime: 629 s

[31/496] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[33/496] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[473/496] Running seeder test suite
PASSED: seeder test suite
[481/496] Running pow test suite
PASSED: pow test suite
[483/496] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[490/496] Running avalanche test suite
PASSED: avalanche test suite
[495/496] Running bitcoin test suite
PASSED: bitcoin test suite
Build build-tsan completed successfully

Revision Contents
Changeset List

PathSize
src/
2 lines
avalanche/
test/
2 lines
bench/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
common/
util/
6 lines
2 lines
2 lines
2 lines
2 lines
interfaces/
2 lines
2 lines
2 lines
networks/
abc/
2 lines
node/
2 lines
2 lines
policy/
2 lines
pow/
2 lines
2 lines
qt/
2 lines
2 lines
2 lines
2 lines
test/
2 lines
2 lines
2 lines
rpc/
2 lines
2 lines
test/
2 lines
script/
2 lines
2 lines
seeder/
test/
2 lines
test/
2 lines
2 lines
2 lines
2 lines
fuzz/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
util/
2 lines
2 lines
2 lines
2 lines
util/
2 lines
2 lines
wallet/
2 lines
2 lines
2 lines
2 lines
2 lines
test/
2 lines
2 lines
2 lines
2 lines
2 lines
zmq/
2 lines

Diff 47935

View Options

src/CMakeLists.txt

Loading...
View Options

src/avalanche/test/init_tests.cpp

Loading...
View Options

src/bench/chained_tx.cpp

Loading...
View Options

src/bench/checkqueue.cpp

Loading...
View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoin-wallet.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/blockencodings.cpp

Loading...
View Options

src/common/system.h

Loading...
View Options

src/common/system.cpp

Loading...
View Options

src/core_write.cpp

Loading...
View Options

src/dbwrapper.h

Loading...
View Options

src/init.h

Loading...
View Options

src/interfaces/handler.cpp

Loading...
View Options

src/mapport.cpp

Loading...
View Options

src/net_permissions.cpp

Loading...
View Options

src/networks/abc/checkpoints.cpp

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/node/kernel_notifications.cpp

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/pow/pow.cpp

Loading...
View Options

src/protocol.cpp

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/qt/splashscreen.cpp

Loading...
View Options

src/qt/test/optiontests.cpp

Loading...
View Options

src/qt/test/rpcnestedtests.cpp

Loading...
View Options

src/radix.h

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/test/server_tests.cpp

Loading...
View Options

src/script/scriptcache.cpp

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/seeder/test/p2p_messaging_tests.cpp

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

src/test/allocator_tests.cpp

Loading...
View Options

src/test/bloom_tests.cpp

Loading...
View Options

src/test/fixture.cpp

Loading...
View Options

src/test/fuzz/integer.cpp

Loading...
View Options

src/test/fuzz/string.cpp

Loading...
View Options

src/test/getarg_tests.cpp

Loading...
View Options

src/test/i2p_tests.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/mempool_tests.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/rpc_server_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/settings_tests.cpp

Loading...
View Options

src/test/sighash_tests.cpp

Loading...
View Options

src/test/sock_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/test/util/setup_common.cpp

Loading...
View Options

src/test/validation_tests.cpp

Loading...
View Options

src/txdb.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/util/error.cpp

Loading...
View Options

src/util/sock.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/bdb.h

Loading...
View Options

src/wallet/coinselection.cpp

Loading...
View Options

src/wallet/crypter.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/spend.cpp

Loading...
View Options

src/wallet/test/init_test_fixture.cpp

Loading...
View Options

src/wallet/test/init_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallettool.cpp

Loading...
View Options

src/warnings.cpp

Loading...
View Options

src/zmq/zmqpublishnotifier.cpp

Loading...