Differential D1746

add SeedNodes to CConnman::Options
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 11:32.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGda2e85082e6e: add SeedNodes to CConnman::Options
rABCda2e85082e6e: add SeedNodes to CConnman::Options

Summary

Start of a series of changes to clean up the instantiation of connman
by decoupling the command line arguments.

This is backport of core PR10467

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

corepr10467

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3239
Build 4565: Bitcoin ABC Buildbot (legacy)
Build 4564: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 10 2018, 11:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 11:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1747: Add Binds, WhiteBinds, Whitelistedrange to CConnman::Options.Sep 10 2018, 11:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3239: Diff 4831.Sep 10 2018, 12:09

schancel accepted this revision.Sep 10 2018, 19:36

This revision is now accepted and ready to land.Sep 10 2018, 19:36

Closed by commit rABCda2e85082e6e: add SeedNodes to CConnman::Options (authored by Marko Bencun <marko.bencun@monetas.net>, committed by deadalnix). · Explain WhySep 10 2018, 19:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

10 lines

net.h

4 lines

net.cpp

8 lines

Diff 4831

View Options

src/init.cpp

View Options

src/net.h

View Options

add SeedNodes to CConnman::OptionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4831

src/init.cpp

src/net.h

src/net.cpp

add SeedNodes to CConnman::Options
ClosedPublic
Actions

Revision Contents
Changeset List