[rpc] return effective-includes in testmempoolaccept and submitpackage
ClosedPublic
Actions

Authored by Fabien on Jul 1 2024, 21:06.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

Summary

Depends on D16398.

Using TxId instead of WTxId.

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Branch

PR26646_5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29433
Build 58402: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58401: arc lint + arc unit

Fabien requested review of this revision.Jul 1 2024, 21:06

Rebase

Not blocking on this feedback but the keys should ideally be the same and the help text should match

src/rpc/mempool.cpp
175	Result key is "size" in ABC
837	Strange that the key is actually "vsize" for submitpackage

This revision is now accepted and ready to land.Jul 1 2024, 23:10

src/rpc/mempool.cpp
175	Yes this is something that needs to be fixed, but here vsize is correct. The mempool minimal fee policy is based on vsize (size + sigchecks) while the relay policy is only based on size. The RPCs are also all over the place (see comment: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/rpc_packages.py$404) I will leave it as-is as the doc is correct, despite the RPC returning size.
837	Same issue as above