[Chronik] Add `ParseChronikParams` and use it in chronik::Start
ClosedPublic
Actions

Authored by tobias_ruck on Jun 28 2024, 19:13.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Commits

rABC99bd71b032b5: [Chronik] Add `ParseChronikParams` and use it in chronik::Start

Summary

This separates this code into its own function, something we eventually could test also.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-refactor-parse-args

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29457
Build 58450: Build Diff	chronik-client-integration-tests · ecash-lib-integration-tests · ecash-agora-integration-tests · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-chronik · build-diff · build-clang · build-chronik-plugins
Build 58449: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jun 28 2024, 19:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2024, 19:13

tobias_ruck requested review of this revision.Jun 28 2024, 19:13

Harbormaster completed remote builds in B29414: Diff 48414.Jun 28 2024, 20:15

PiRK requested changes to this revision.Jun 29 2024, 11:43

PiRK added a subscriber: PiRK.

PiRK added inline comments.

chronik/chronik-cpp/chronik.cpp
41–70 ↗	(On Diff #48414)

This revision now requires changes to proceed.Jun 29 2024, 11:43

This looks like a good first step to remove most gArgs access (eventually we want the ArgsManager to not be a global).

A next step would be to make chronik not depend on common/args.h (ArgsManager) at all, like we recently did for ChainstateManager, BlockManager (see D16007 for instance) ...