Paths

Table of Contentst

Differential D16492

[Cashtab] Add chronik method to get all tx history by lokad id
ClosedPublic
Actions

Authored by bytesofman on Jul 17 2024, 18:17.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCf10df4556c1c: [Cashtab] Add chronik method to get all tx history by lokad id

Summary

Add helper function to get all tx history by lokad id. This will be used to support NFT trading. See D16328 for implementation.

This diff does not implement the method. Only adds it + adds tests, to reduce review sprawl of D16328.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lokadid-history-fn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29609
Build 58753: Build Diff	ecash-lib-tests · cashtab-tests
Build 58752: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 17 2024, 18:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2024, 18:17

fix test for page size, better naming for lokad function

Harbormaster completed remote builds in B29609: Diff 48701.Jul 17 2024, 18:57

Harbormaster completed remote builds in B29610: Diff 48702.Jul 17 2024, 19:00

bytesofman published this revision for review.Jul 17 2024, 20:13

minor nit

cashtab/src/chronik/__tests__/index.test.js
500 ↗	(On Diff #48702)

This revision is now accepted and ready to land.Jul 18 2024, 09:11

Closed by commit rABCf10df4556c1c: [Cashtab] Add chronik method to get all tx history by lokad id (authored by bytesofman). · Explain WhyJul 18 2024, 13:00

This revision was automatically updated to reflect the committed changes.

bytesofman marked an inline comment as done.

bytesofman added a commit: rABCf10df4556c1c: [Cashtab] Add chronik method to get all tx history by lokad id.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

chronik/

__tests__/

index.test.js

47 lines

index.js

50 lines

Diff 48701

View Options

cashtab/src/chronik/tests/index.test.js

View Options

cashtab/src/chronik/index.js

[Cashtab] Add chronik method to get all tx history by lokad idClosedPublicActions