Page MenuHomePhabricator
Differential D16512

[Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat
ClosedPublic
Actions

Authored by emack on Jul 21 2024, 15:49.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABC9975eba9a1ed: [Cashtab] Update TxHistory to recognize article post and article reply txs from…
Summary

Update tx history parsing to recognize the lokaid IDs for eCashChat actions in submitting an article and a reply to an article.

Article reply before

image.png (642×898 px, 383 KB)

Article reply after

image.png (317×824 px, 115 KB)

Article post before

image.png (403×895 px, 160 KB)

Article post after

image.png (216×829 px, 54 KB)

Test Plan

npm test
click on the article link on an article reply tx in tx history and ensure it takes the user to the direct article on eCashChat

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashchatActionUpdate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29647
Build 58829: Build Diffecash-lib-tests · cashtab-tests
Build 58828: arc lint + arc unit

Event Timeline

emack created this revision.Jul 21 2024, 15:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2024, 15:49
emack edited the summary of this revision. (Show Details)Jul 21 2024, 15:51
Harbormaster completed remote builds in B29647: Diff 48759.Jul 21 2024, 15:53
emack edited the test plan for this revision. (Show Details)Jul 21 2024, 15:55
emack updated this revision to Diff 48760.Jul 21 2024, 16:01

Remove debug log

Harbormaster completed remote builds in B29648: Diff 48760.Jul 21 2024, 16:05
emack updated this revision to Diff 48761.Jul 21 2024, 16:05

Updated comments

Harbormaster completed remote builds in B29649: Diff 48761.Jul 21 2024, 16:09
emack published this revision for review.Jul 21 2024, 16:12
Fabien requested changes to this revision.Jul 22 2024, 07:39
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/components/Home/Tx/index.js
464 ↗(On Diff #48761)

You didn't check the stackArray size, this could very well be an out of bounds access

This revision now requires changes to proceed.Jul 22 2024, 07:39
emack updated this revision to Diff 48925.Jul 30 2024, 14:00
emack marked an inline comment as done.

Added stackArray size check and updated int tests

Harbormaster completed remote builds in B29785: Diff 48925.Jul 30 2024, 14:04
emack updated this revision to Diff 48928.Jul 30 2024, 14:12

version bump

Harbormaster completed remote builds in B29787: Diff 48928.Jul 30 2024, 15:06
Fabien accepted this revision.Aug 1 2024, 09:42
This revision is now accepted and ready to land.Aug 1 2024, 09:42
Closed by commit rABC9975eba9a1ed: [Cashtab] Update TxHistory to recognize article post and article reply txs from… (authored by emack). · Explain WhyAug 2 2024, 05:00
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABC9975eba9a1ed: [Cashtab] Update TxHistory to recognize article post and article reply txs from….

Revision Contents
Changeset List

PathSize
cashtab/
src/
chronik/
fixtures/
291 lines
components/
Home/
Tx/
__tests__/
160 lines
54 lines
config/
2 lines

Diff 48759

View Options

cashtab/src/chronik/fixtures/mocks.js

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...
View Options

cashtab/src/components/Home/Tx/index.js

Loading...
View Options

cashtab/src/config/opreturn.js

Loading...