Page MenuHomePhabricator
Differential D1777

moveonly: factor out headers processing into separate function
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 15:06.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9e4326e0b834: moveonly: factor out headers processing into separate function
rABC9e4326e0b834: moveonly: factor out headers processing into separate function
Summary

ProcessMessages will now return earlier when processing headers
messages, rather than continuing on (and do nothing).

This is part of Core PR11568

Depends on D1764

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr11568moveonly
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3286
Build 4658: Bitcoin ABC Buildbot (legacy)
Build 4657: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2018, 15:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 15:06
teamcity added a subscriber: teamcity.Sep 12 2018, 15:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 4899.Sep 12 2018, 15:22

Remove unused parameter

teamcity added a comment.Sep 12 2018, 15:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 12 2018, 15:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3285: Diff 4898.Sep 12 2018, 15:41
teamcity added a comment.Sep 12 2018, 15:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3286: Diff 4899.Sep 12 2018, 15:57
deadalnix added a child revision: D1778: Disconnect outbound peers relaying invalid headers.Sep 12 2018, 16:36
schancel accepted this revision.Sep 15 2018, 14:55
This revision is now accepted and ready to land.Sep 15 2018, 14:55
deadalnix updated this revision to Diff 4930.Sep 15 2018, 17:48

rebase

teamcity added a comment.Sep 15 2018, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3307: Diff 4930.Sep 15 2018, 19:23
teamcity added a comment.Sep 15 2018, 19:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC9e4326e0b834: moveonly: factor out headers processing into separate function (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhySep 17 2018, 07:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
433 lines

Diff 4899

View Options

src/net_processing.cpp

Loading...