Connect to a new outbound peer if our tip is stale
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 18:16.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING59ff0f4a3d40: Connect to a new outbound peer if our tip is stale
rABC59ff0f4a3d40: Connect to a new outbound peer if our tip is stale

Summary

net: Allow connecting to extra outbound peers
Track tip update time and last new block announcement from each peer
Add CConnmanTest to mutate g_connman in tests
Connect to an extra outbound peer if our tip is stale

If our tip hasn't updated in a while, that may be because our peers are
not relaying blocks to us that we would consider valid. Allow connection
to an additional outbound peer in that circumstance.

Also, periodically check to see if we are exceeding our target number of
outbound peers, and disconnect the one which has least recently
announced a new block to us (choosing the newest such peer in the case
of tie).

Add scheduler to the testing setup
Add unit test for stale tip checking

This is a backport of core PR11560

Depends on D1778 and D1776

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

corepr11560

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3292
Build 4670: Bitcoin ABC Buildbot (legacy)
Build 4669: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2018, 18:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3289: Diff 4902!Sep 12 2018, 18:52

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3292: Diff 4905.Sep 12 2018, 19:48

schancel accepted this revision.Sep 18 2018, 02:28

schancel added a subscriber: schancel.

schancel added inline comments.

src/net_processing.cpp
3455	if (extra_peers <= 0) { return; }
3488	if(worst_peer == -1) { return; }
3536	if (time_in_seconds < m_stale_tip_check_time) { // Tip not stale, no need to try new outbound peers return; }