Differential D16649

[avalanche] Return a specific vote value for conflicting txs
ClosedPublic
Actions

Authored by Fabien on Aug 15 2024, 13:13.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC88b5d8c481e2: [avalanche] Return a specific vote value for conflicting txs

Summary

So we can distinguish from other invalid txs.

Depends on D16645 and D16648.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

vote__error_conflicting

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29994
Build 59522: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 59521: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 15 2024, 13:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2024, 13:13

Fabien requested review of this revision.Aug 15 2024, 13:13

Harbormaster completed remote builds in B29994: Diff 49229.Aug 15 2024, 13:39

Fabien added a child revision: D16650: [avalanche] Reject transactions that conflict with a finalized one.Aug 15 2024, 14:43

bytesofman accepted this revision.Aug 15 2024, 17:20

This revision is now accepted and ready to land.Aug 15 2024, 17:20

Closed by commit rABC88b5d8c481e2: [avalanche] Return a specific vote value for conflicting txs (authored by Fabien). · Explain WhyAug 16 2024, 09:41

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC88b5d8c481e2: [avalanche] Return a specific vote value for conflicting txs.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

7 lines

test/

functional/

abc_p2p_avalanche_transaction_voting.py

20 lines

test_framework/

messages.py

1 line

Diff 49229

View Options

src/net_processing.cpp

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/test_framework/messages.py

[avalanche] Return a specific vote value for conflicting txsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49229

src/net_processing.cpp

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/test_framework/messages.py

[avalanche] Return a specific vote value for conflicting txs
ClosedPublic
Actions

Revision Contents
Changeset List