Page MenuHomePhabricator
Differential D16738

[Cashtab] Remove unimplemented agora methods
ClosedPublic
Actions

Authored by bytesofman on Sep 9 2024, 23:53.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCc017c46f6152: [Cashtab] Remove unimplemented agora methods
Summary

These methods were necessary to implement NFT trading using LOKAD ID to get all information about active offers. Recent upgrades to ecash-agora have made this method obsolete.

See D16328. Cashtab is now able to get these methods without specialized agora parsing.

Remove it.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
agora-methods-out-of-cashtab
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30224
Build 59975: Build Diffcashtab-tests · ecash-lib-tests
Build 59974: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 9 2024, 23:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2024, 23:53
Harbormaster completed remote builds in B30224: Diff 49550.Sep 9 2024, 23:56
bytesofman published this revision for review.Sep 10 2024, 00:17
bytesofman retitled this revision from [Cashtab] Remove agora methods from Cashtab to [Cashtab] Remove unimplemented agora methods from Cashtab.
bytesofman retitled this revision from [Cashtab] Remove unimplemented agora methods from Cashtab to [Cashtab] Remove unimplemented agora methods.
emack accepted this revision.Sep 10 2024, 11:10
This revision is now accepted and ready to land.Sep 10 2024, 11:10
Closed by commit rABCc017c46f6152: [Cashtab] Remove unimplemented agora methods (authored by bytesofman). · Explain WhySep 10 2024, 16:41
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCc017c46f6152: [Cashtab] Remove unimplemented agora methods.

Revision Contents
Changeset List

PathSize
cashtab/
src/
agora/
__tests__/
fixtures/

Diff 49550

View Options

cashtab/src/agora/__tests__/index.test.js

Loading...
View Options

cashtab/src/agora/fixtures/vectors.js

Loading...
View Options

cashtab/src/agora/index.js

Loading...