[ecash-herald] Stop handling block connected event
ClosedPublic
Actions

Authored by bytesofman on Oct 14 2024, 16:18.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC29ca08179cc6: [ecash-herald] Stop handling block connected event

Summary

Now that we build more helpful messages for blocks that are invalidated by avalanche, stop "guessing" that blocks have a problem if they are connected by not finalized after an arbitrary amount of time.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-no-timeouts

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30594
Build 60704: Build Diff	ecash-herald-tests
Build 60703: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 14 2024, 16:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2024, 16:18

Harbormaster completed remote builds in B30586: Diff 50081.Oct 14 2024, 16:20

update cache ttl

bytesofman published this revision for review.Oct 14 2024, 16:23

Harbormaster completed remote builds in B30587: Diff 50082.Oct 14 2024, 16:24

For the next follow-up: you can remove the memoryCache entry for the block status as well as it's no longer needed

apps/ecash-herald/config.js
7 ↗	(On Diff #50082)	I would increase it a bit, like 4 hours so we handle even long time with no block
apps/ecash-herald/src/main.js
16 ↗	(On Diff #50082)	You don't need the 2x here