Page MenuHomePhabricator
Differential D16997

[64-bit ints] Refactor `CScriptNum` to require setting `nMaxNumSize`
DraftPublic
Actions

Authored by tobias_ruck on Oct 25 2024, 00:21.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Currently, CScriptNum's constructor and IsMinimallyEncoded have a default for nMaxNumSize, which defaults to 4 (eCash's maximum integer size).

For upgrading Script integers from 32-bit to 64-bit, having to make the integer size explicit allows us to upgrade them based on a script flag.

This has no change in behavior.

Depends on D16996.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
interpreter-refactor-script-num-size
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30827
Build 61167: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 61166: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
5 lines
script/
33 lines
9 lines
test/
6 lines
6 lines

Diff 50418

View Options

src/core_write.cpp

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/test/monolith_opcodes_tests.cpp

Loading...
View Options

src/test/scriptnum_tests.cpp

Loading...