Use std::string_view throughout util strencodings/string
Needs ReviewPublic
Actions

Authored by PiRK on Sat, Nov 16, 10:39.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Use std::string_view throughout util strencodings/string

https://github.com/bitcoin/bitcoin/pull/25001/commits/e7d2fbda63c346ae88767c3f8d4db3edeae2dc0b

Replace use of boost::trim use with locale-independent TrimString

Replace use of boost::trim_right with locale-independent TrimString

Note the only use of readStdin is fed to DecodeHexTx, which fails in
IsHex on non-hex characters as recorded in p_util_hexdigit.

tests: Add TrimString(...) tests

This is a partial backport of core#25001 and core#22859

Depends on D17150

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31172
Build 61844: Build Diff	lint-circular-dependencies · build-fuzzer · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 61843: arc lint + arc unit

Event Timeline

PiRK created this revision.Sat, Nov 16, 10:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Nov 16, 10:39

PiRK requested review of this revision.Sat, Nov 16, 10:39

teamcity edited the summary of this revision. (Show Details)Sat, Nov 16, 10:39

PiRK added a child revision: D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.Sat, Nov 16, 10:42

PiRK added inline comments.Sat, Nov 16, 10:44

src/httprpc.cpp
18 ↗	(On Diff #50889)	still needed. Can be remove if/when we grab core#25057

Harbormaster completed remote builds in B31167: Diff 50889.Sat, Nov 16, 11:05

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[379/575] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[380/575] Linking C executable src/secp256k1/internal-bench
[381/575] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[382/575] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[383/575] Linking C executable src/secp256k1/ecmult-bench
[384/575] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[385/575] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[386/575] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[387/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[388/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[389/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[390/575] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[391/575] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[392/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[393/575] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[394/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[395/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[396/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[397/575] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[398/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[399/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[400/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[401/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[402/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[403/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[404/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[405/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[406/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[407/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[408/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[409/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[410/575] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[411/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[412/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[413/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[414/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[415/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[416/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[417/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[418/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[419/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[420/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[421/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[422/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[423/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[424/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[425/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[426/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[427/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[428/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[429/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[430/575] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[431/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[432/575] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[433/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[434/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[435/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[436/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

rebase

Harbormaster completed remote builds in B31172: Diff 50894.Sat, Nov 16, 12:03