Page MenuHomePhabricator
Differential D17177

[chronik-client] Support isFinal key for Tx
ClosedPublic
Actions

Authored by bytesofman on Thu, Nov 21, 04:22.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC824e210996cc: [chronik-client] Support isFinal key for Tx
Summary

Add the now-in-chronik isFinal key to the Tx object returned by chronik-client

Confirm with tests

Update ecash-lib tests and Cashtab types to match the change (otherwise this diff will break those apps).

Test Plan

npm test and CI tests for downstream libs / apps

cd apps/ecash-herald && npm test, works

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Thu, Nov 21, 04:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 21, 04:22
Harbormaster completed remote builds in B31241: Diff 51001.Thu, Nov 21, 04:28
teamcity added a comment.Thu, Nov 21, 04:28
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Failed tests logs:

====== ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/alp.test.ts:264:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a5021534c5032000747454e455349530000000000000264000000000000000000000001010143534c5032000453454e44e448f2b4bf386acdcd009f7a9efd7453792f1a548de9b0911190ee1e2cbefeb804000000000000e80300000000000000000000dc0500000000"
====== SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:262:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001010453454e44205a002808245882822d785a5d83f37b1f96dc1a0dc1f3be71a3cfd7f72bd221340800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:623:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001020453454e44202861547c024c020b951b6286184730f46df686e8d7574db685cf9b434450bef30800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1 ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:893:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001810453454e442022bf81956c77e83a1e7603660eadaf3f978a5b85cea83bf280fa20fd462af5c70800000000000000010800000000000009c3"

Each failure log is accessible here:
ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP
SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE
SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT
SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1

bytesofman updated this revision to Diff 51024.Thu, Nov 21, 19:35

confine tests to script_endpoints which finalizes a block, add more tests

Harbormaster completed remote builds in B31257: Diff 51024.Thu, Nov 21, 19:44
teamcity added a comment.Thu, Nov 21, 19:44
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Failed tests logs:

====== ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/alp.test.ts:264:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a5021534c5032000747454e455349530000000000000264000000000000000000000001010143534c5032000453454e44e448f2b4bf386acdcd009f7a9efd7453792f1a548de9b0911190ee1e2cbefeb804000000000000e80300000000000000000000dc0500000000"
====== SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:262:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001010453454e44205a002808245882822d785a5d83f37b1f96dc1a0dc1f3be71a3cfd7f72bd221340800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:623:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001020453454e44202861547c024c020b951b6286184730f46df686e8d7574db685cf9b434450bef30800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1 ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:893:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001810453454e442022bf81956c77e83a1e7603660eadaf3f978a5b85cea83bf280fa20fd462af5c70800000000000000010800000000000009c3"

Each failure log is accessible here:
ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP
SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE
SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT
SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1

bytesofman updated this revision to Diff 51025.Thu, Nov 21, 19:52

simplify test, confirm passing with rebuilt node

bytesofman updated this revision to Diff 51026.Thu, Nov 21, 19:55

changelog

Harbormaster completed remote builds in B31259: Diff 51026.Thu, Nov 21, 20:00
teamcity added a comment.Thu, Nov 21, 20:00
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Failed tests logs:

====== ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/alp.test.ts:264:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a5021534c5032000747454e455349530000000000000264000000000000000000000001010143534c5032000453454e44e448f2b4bf386acdcd009f7a9efd7453792f1a548de9b0911190ee1e2cbefeb804000000000000e80300000000000000000000dc0500000000"
====== SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:262:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001010453454e44205a002808245882822d785a5d83f37b1f96dc1a0dc1f3be71a3cfd7f72bd221340800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:623:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001020453454e44202861547c024c020b951b6286184730f46df686e8d7574db685cf9b434450bef30800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1 ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:893:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001810453454e442022bf81956c77e83a1e7603660eadaf3f978a5b85cea83bf280fa20fd462af5c70800000000000000010800000000000009c3"

Each failure log is accessible here:
ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP
SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE
SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT
SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1

Harbormaster completed remote builds in B31258: Diff 51025.Thu, Nov 21, 20:01
teamcity added a comment.Thu, Nov 21, 20:01
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Failed tests logs:

====== ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/alp.test.ts:264:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a5021534c5032000747454e455349530000000000000264000000000000000000000001010143534c5032000453454e44e448f2b4bf386acdcd009f7a9efd7453792f1a548de9b0911190ee1e2cbefeb804000000000000e80300000000000000000000dc0500000000"
====== SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:262:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001010453454e44205a002808245882822d785a5d83f37b1f96dc1a0dc1f3be71a3cfd7f72bd221340800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:623:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001020453454e44202861547c024c020b951b6286184730f46df686e8d7574db685cf9b434450bef30800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1 ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:893:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001810453454e442022bf81956c77e83a1e7603660eadaf3f978a5b85cea83bf280fa20fd462af5c70800000000000000010800000000000009c3"

Each failure log is accessible here:
ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP
SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE
SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT
SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1

bytesofman updated this revision to Diff 51027.Thu, Nov 21, 20:12

update ecash-lib tests for new chronik-client

teamcity added a comment.Thu, Nov 21, 20:13
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Failed tests logs:

====== ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/alp.test.ts:264:38)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a5021534c5032000747454e455349530000000000000264000000000000000000000001010143534c5032000453454e44e448f2b4bf386acdcd009f7a9efd7453792f1a548de9b0911190ee1e2cbefeb804000000000000e80300000000000000000000dc0500000000"
====== SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:262:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001010453454e44205a002808245882822d785a5d83f37b1f96dc1a0dc1f3be71a3cfd7f72bd221340800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:623:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001020453454e44202861547c024c020b951b6286184730f46df686e8d7574db685cf9b434450bef30800000000000003e80800000000000005dc"
====== SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1 ======
AssertionError: expected { …(12) } to deeply equal { …(11) }
    at Context.<anonymous> (tests/slp.test.ts:893:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

      + expected - actual

             "value": 10000
           }
         ]
         "isCoinbase": false
      -  "isFinal": false
         "lockTime": 0
         "outputs": [
           {
             "outputScript": "6a04534c500001810453454e442022bf81956c77e83a1e7603660eadaf3f978a5b85cea83bf280fa20fd462af5c70800000000000000010800000000000009c3"

Each failure log is accessible here:
ALP: TxBuilder P2PKH ALP.ALP TxBuilder P2PKH ALP
SLP Integration Test: TxBuilder P2PKH SLP FUNGIBLE.SLP Integration Test TxBuilder P2PKH SLP FUNGIBLE
SLP Integration Test: TxBuilder P2PKH SLP MINT VAULT.SLP Integration Test TxBuilder P2PKH SLP MINT VAULT
SLP Integration Test: TxBuilder P2PKH SLP NFT1.SLP Integration Test TxBuilder P2PKH SLP NFT1

Harbormaster completed remote builds in B31260: Diff 51027.Thu, Nov 21, 20:15
teamcity added a comment.Thu, Nov 21, 20:15
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 256 |                         txType: 'SEND',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 257 |                         isInvalid: false,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 258 |                         burnSummary: '',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 259 |                         failedColorings: [],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 260 |                         actualBurnAmount: '0',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 261 |                         intentionalBurn: '0',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 262 |                         burnsMintBatons: false,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 263 |                     },
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 264 |                 ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 265 |                 tokenFailedParsings: [],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 266 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 267 |                 parsed: {
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 268 |                     xecTxType: XecTxType.Received,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 269 |                     satoshisSent: 546,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 270 |                     stackArray: [
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 271 |                         '534c5000',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 272 |                         '01',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 273 |                         '53454e44',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 274 |                         '3fee3384150b030490b7bee095a63900f66a45f2d8e3002ae2cf17ce3ef4d109',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 275 |                         '0000000000000001',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 276 |                         '0000000000000377',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 277 |                     ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 278 |                     recipients: [
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 279 |                         'ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 280 |                     ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 281 |                 },
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 282 |             },
        | ^^^^^^^^^^^^^^
    283 |             {
    284 |                 txid: '218a1e058ed0fda76573eabf43ad3ded7e7192e42621893a60aaa152ba7f66fe',
    285 |                 version: 2,

Build cashtab-tests failed with exit code 1
teamcity added a comment.Thu, Nov 21, 20:22
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 256 |                         txType: 'SEND',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 257 |                         isInvalid: false,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 258 |                         burnSummary: '',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 259 |                         failedColorings: [],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 260 |                         actualBurnAmount: '0',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 261 |                         intentionalBurn: '0',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 262 |                         burnsMintBatons: false,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 263 |                     },
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 264 |                 ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 265 |                 tokenFailedParsings: [],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 266 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 267 |                 parsed: {
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 268 |                     xecTxType: XecTxType.Received,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 269 |                     satoshisSent: 546,
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 270 |                     stackArray: [
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 271 |                         '534c5000',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 272 |                         '01',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 273 |                         '53454e44',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 274 |                         '3fee3384150b030490b7bee095a63900f66a45f2d8e3002ae2cf17ce3ef4d109',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 275 |                         '0000000000000001',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 276 |                         '0000000000000377',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 277 |                     ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 278 |                     recipients: [
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 279 |                         'ecash:qp89xgjhcqdnzzemts0aj378nfe2mhu9yvxj9nhgg6',
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 280 |                     ],
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 281 |                 },
        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  > 282 |             },
        | ^^^^^^^^^^^^^^
    283 |             {
    284 |                 txid: '218a1e058ed0fda76573eabf43ad3ded7e7192e42621893a60aaa152ba7f66fe',
    285 |                 version: 2,

Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51028.Thu, Nov 21, 20:35

update cashtab types

Harbormaster completed remote builds in B31261: Diff 51028.Thu, Nov 21, 20:43
bytesofman published this revision for review.Thu, Nov 21, 21:08
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
bytesofman updated this revision to Diff 51034.Thu, Nov 21, 23:07

also update types in ecash-herald

bytesofman edited the test plan for this revision. (Show Details)Thu, Nov 21, 23:07
bytesofman updated this revision to Diff 51035.Thu, Nov 21, 23:10

update types for token-server, update CI to run token-server and ecash-herald tests when chronik-client changes

bytesofman mentioned this in D17182: [ecash-herald] Update test mocks to match new chronik type.Thu, Nov 21, 23:11
Harbormaster completed remote builds in B31266: Diff 51034.Thu, Nov 21, 23:16
Harbormaster completed remote builds in B31267: Diff 51035.Thu, Nov 21, 23:20
emack accepted this revision.Thu, Nov 21, 23:20
This revision is now accepted and ready to land.Thu, Nov 21, 23:20
Closed by commit rABC824e210996cc: [chronik-client] Support isFinal key for Tx (authored by bytesofman). · Explain WhyThu, Nov 21, 23:56
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC824e210996cc: [chronik-client] Support isFinal key for Tx.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
test/
mocks/
30 lines
4 lines
token-server/
test/
1 line
cashtab/
src/
components/
App/
fixtures/
11 lines
contrib/
teamcity/
2 lines
modules/
chronik-client/
1 line
4 lines
2 lines
proto/
22 lines
src/
5 lines
test/
integration/
16 lines
ecash-lib/
tests/
1 line
5 lines

Diff 51043

View Options

apps/ecash-herald/test/mocks/dailyTxs.ts

Loading...
View Options

apps/ecash-herald/test/mocks/mockChronikCalls.ts

Loading...
View Options

apps/token-server/test/vectors.ts

Loading...
View Options

cashtab/src/components/App/fixtures/mocks.ts

Loading...
View Options

contrib/teamcity/build-configurations.yml

Loading...
View Options

modules/chronik-client/README.md

Loading...
View Options

modules/chronik-client/package-lock.json

Loading...
View Options

modules/chronik-client/package.json

Loading...
View Options

modules/chronik-client/proto/chronik.ts

Loading...
View Options

modules/chronik-client/src/ChronikClient.ts

Loading...
View Options

modules/chronik-client/test/integration/script_endpoints.ts

Loading...
View Options

modules/ecash-lib/tests/alp.test.ts

Loading...
View Options

modules/ecash-lib/tests/slp.test.ts

Loading...