newline

newline

This file is testing the lib?

Does the test plan of this diff run these tests?

It's difficult to review these tests. Seems like there are a lot of tests, but not a lot of language to show what the tests are demonstrating.

mb something like this? I'm not sure how tests are usually organized in rust. but should be some way for a reviewer to see what is being tested without translating the code for every test.

Let’s point this to /chronik/chronik-proto/proto/chronik.proto right away

Let’s remove these two P2tr already

Don’t do this, instead just import from the dependency directly where needed

Add a copyright notice

I think we should just use chronik-proto instead of compiling again

Instead of compiling the proto again, maybe we can already just import chronik-proto from /chronik

Actually fill in the comment or remove it

move it up to the other local dependencies:) frens need frens

This is problematic. We don't test against production servers because there is no way to make sure the version is synced, and this subject to failures if the server goes down.
The solution is to build and run a server on the regtest chain (cpu mined chain for regression testing) and test against that using the local network. This is what is done for the ts client for example, leveraging the node test framework. This should be fixed in another diff.

But for now using Tobias' production server is not a good option. You can use the public ABC node instead https://chronik.e.cash until the root issue is fixed.

add the (standard) copyright (I'm the author anyway so it's fine)

see suggestion below

I used to do that but we should really move this into the use statements above (see suggestion in the top)

same here

Can you try just using #[tokio::test] for as many as possible here? That should simplify the code some more

let's remove this