Paths

Table of Contentst

Differential D17566

[e.cash] Remove eCashPoker
ClosedPublic
Actions

Authored by Mengerian on Mon, Jan 20, 04:13.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1411155e9162: [e.cash] Remove eCashPoker

Test Plan

Ran the site locally, check that Use eCash page looks fine and the poker section is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

e.cash-remove-poker

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32166
Build 63822: Build Diff
Build 63821: arc lint + arc unit

Event Timeline

Mengerian created this revision.Mon, Jan 20, 04:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 20, 04:13

Mengerian requested review of this revision.Mon, Jan 20, 04:13

Harbormaster completed remote builds in B32163: Diff 52308.Mon, Jan 20, 04:13

bytesofman requested changes to this revision.Mon, Jan 20, 08:08

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

web/e.cash/package-lock.json
544 ↗	(On Diff #52308)	back out these unrelated package-lock.json changes easiest way is to just copy paste the "show file on the left" from this diff

This revision now requires changes to proceed.Mon, Jan 20, 08:08

Fabien added a subscriber: Fabien.Mon, Jan 20, 08:09

Fabien added inline comments.

web/e.cash/package-lock.json
544 ↗	(On Diff #52308)	Why did they appear in the first place ? Running `npm install` instead of `npm ci` ?

greening this as I don't want to block it when I go to bed, but the package-lock.json changes should be backed out before landing

This revision is now accepted and ready to land.Mon, Jan 20, 10:58

Back out unrelated package-lock.json changes

Harbormaster completed remote builds in B32166: Diff 52315.Mon, Jan 20, 17:04

Closed by commit rABC1411155e9162: [e.cash] Remove eCashPoker (authored by Mengerian). · Explain WhyMon, Jan 20, 17:11

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rABC1411155e9162: [e.cash] Remove eCashPoker.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

20 lines

public/

images/

ecash-poker-logo.png

Diff 52315

web/e.cash/pages/use-ecash.js

Loading...

web/e.cash/public/images/ecash-poker-logo.png

Loading...