Page MenuHomePhabricator

[ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo
ClosedPublic

Authored by bytesofman on Mar 4 2025, 18:54.

Details

Summary

Should have been done when it was deprecated from token-server. Looks like it is still in the token-server package-lock.json as an artifact. Clean up. Remove.

The logic from ecash-coinselect is obsolete and does not work with ecash-lib. Will be implemented in upcoming wallet lib.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
no-more-coinselect
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32592
Build 64672: Build Diffecash-coinselect-tests · token-server-tests
Build 64671: arc lint + arc unit

Event Timeline

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman published this revision for review.Mar 4 2025, 21:57

CI failure expected with the lib removed.

token-server tests and builds pass locally

This revision is now accepted and ready to land.Mar 4 2025, 22:23
This revision was landed with ongoing or failed builds.Mar 5 2025, 16:53
This revision was automatically updated to reflect the committed changes.