Page MenuHomePhabricator
Differential D1891

Added txtools utility functions
ClosedPublic
Actions

Authored by jasonbcox on Oct 5 2018, 20:08.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING60474bba1df0: Added txtools utility functions
rABC60474bba1df0: Added txtools utility functions
Summary

Part 1 of many for incorporating changes from https://github.com/bitcoinxt/bitcoinxt/pull/487
The goal is to improve the test suite so that it doesn't fail post-fork.
Starts work on T418

This diff differs from the original primarily in variable/function naming and other minor cleanups.

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3534
Build 5144: Bitcoin ABC Buildbot (legacy)
Build 5143: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 5 2018, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 20:08
teamcity added a subscriber: teamcity.Oct 5 2018, 20:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Oct 5 2018, 20:09
teamcity added a comment.Oct 5 2018, 20:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3529: Diff 5296.Oct 5 2018, 20:25
deadalnix requested changes to this revision.Oct 6 2018, 09:22
deadalnix added inline comments.
test/functional/test_framework/txtools.py
26 ↗(On Diff #5296)

There was a bug with that in some test. getrandbit can starts with too many zeros once in a while and you'll get something smaller than you expect. Digging into the HF activation test history should give you all the details.

This revision now requires changes to proceed.Oct 6 2018, 09:22
jasonbcox mentioned this in T424: Add helper for generating randbits() with strict length.Oct 8 2018, 18:26
jasonbcox updated this revision to Diff 5312.Oct 8 2018, 18:27

Fixed randbits usage

teamcity added a comment.Oct 8 2018, 18:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 8 2018, 18:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3534: Diff 5312.Oct 8 2018, 18:47
deadalnix accepted this revision.Oct 8 2018, 21:12
deadalnix added inline comments.
test/functional/test_framework/blocktools.py
66

I think we should keep the old school style padding here. It's how it's done by miners in practice.

This revision is now accepted and ready to land.Oct 8 2018, 21:12
Closed by commit rABC60474bba1df0: Added txtools utility functions (authored by dagurval, committed by jasonbcox). · Explain WhyOct 8 2018, 22:58
This revision was automatically updated to reflect the committed changes.
jasonbcox edited the summary of this revision. (Show Details)Oct 12 2018, 22:03

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
6 lines
3 lines
41 lines

Diff 5312

View Options

test/functional/test_framework/blocktools.py

Loading...
View Options

test/functional/test_framework/cdefs.py

Loading...
View Options

test/functional/test_framework/txtools.py

Loading...