rpc: Improve importdescriptor RPC error messages
ClosedPublic
Actions

Authored by PiRK on Sat, Apr 12, 08:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Particularly add more details in the case of pruning or assumeutxo.

see D10159 for GetRescanErrorMessage and why this affects a wallet test that imports keys

Depends on D17926

Test Plan

ninja all check-all

Also covered by another test in wallet_assumeutxo.py on my dev branch

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32952
Build 65388: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 65387: arc lint + arc unit

PiRK created this revision.Sat, Apr 12, 08:01

PiRK requested review of this revision.Sat, Apr 12, 08:01

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/rpc/backup.cpp
1697	layout
1707	Since you're always adding something to the initial message, you'd rather move the space following the dot in the initial message as well and avoid repeating it 3 times