Page MenuHomePhabricator

[avalanche] Delay polling the conflicting transactions
Needs ReviewPublic

Authored by Fabien on Mon, Apr 28, 10:17.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

THe actual behavior is to poll for the mempool transactions and the conflicting transactions. The latter is actually not strictly needed: if a conflicting transaction exists, then there is an associated transaction living in the mempool. Because we pull back the conflicting transactions if the mempool one is rejected, it will naturally be polled as well when it reached the mempool.

This simplifies the logic and avoids some edge cases because mempool transactions have computed all the properties to check if they will fit in a block, despite conflicting transactions don't.

Test Plan
ninja check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_no_poll_conflicting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33127
Build 65737: Build Difflint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang · build-debug · build-diff
Build 65736: arc lint + arc unit