[avalanche] bump the misbehavior for oversized AVAPOLL messages
ClosedPublic
Actions

Authored by PiRK on Tue, Apr 29, 10:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC07d226cbf3a0: [avalanche] bump the misbehavior for oversized AVAPOLL messages

Summary

20 was an arbitrary value. If a node does not format its messages correctly it will get disconnected soon anyway, so don't give it 4 more chances and just disconnect it immediately.

Depends on D18016

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33150
Build 65783: Build Diff	build-clang · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-diff
Build 65782: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Apr 29, 10:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 29, 10:45

PiRK requested review of this revision.Tue, Apr 29, 10:45

Harbormaster completed remote builds in B33150: Diff 53746.Tue, Apr 29, 10:53

PiRK added a child revision: D18018: net_processing: don't bother disconnecting for multiple version messages.Tue, Apr 29, 10:55

This doesn't break any test ? It's certainly time to add one then

This revision now requires changes to proceed.Tue, Apr 29, 13:53

add a test

PiRK added a child revision: D18021: p2p: Ignore version msgs after initial version msg.Tue, Apr 29, 15:46

Harbormaster completed remote builds in B33157: Diff 53756.Tue, Apr 29, 15:49

Fabien accepted this revision.Tue, Apr 29, 16:18

Fabien added inline comments.

test/functional/abc_p2p_avalanche_voting.py
420 ↗	(On Diff #53756)	You don't really need to check for all this, the `f"too-many-ava-poll: poll message size = {msg_avapoll.MAX_ELEMENT_POLL + 1}"` part is enough and will make the test easier to maintain