Page MenuHomePhabricator
Differential D1917

rpc: Push down safe mode checks
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2018, 16:46.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0e05d72275d7: rpc: Push down safe mode checks
rABC0e05d72275d7: rpc: Push down safe mode checks
Summary

This contains most of the changes of 10563 "remove safe mode", but doesn't
remove the safe mode yet, but put an ObserveSafeMode() check in
individual calls with okSafeMode=false.

This cleans up the ugly "okSafeMode" flag from the dispatch tables,
which is not a concern for the RPC server.

Extra-author: Wladimir J. van der Laan <laanwj@gmail.com>

This is a backport of Core PR11179

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
1 line
2 lines
14 lines
qt/
test/
2 lines
rpc/
6 lines
52 lines
16 lines
20 lines
26 lines
23 lines
12 lines
14 lines
13 lines
15 lines
wallet/
25 lines
105 lines

Diff 5383

View Options

doc/release-notes.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/test/rpcnestedtests.cpp

Loading...
View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/safemode.h

Loading...
View Options

src/rpc/safemode.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...