[qt] Move BitcoinGUI initializers to class, fix initializer order warning
ClosedPublic
Actions

Authored by schancel on Oct 22 2018, 21:47.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING58b7c73e214d: [qt] Move BitcoinGUI initializers to class, fix initializer order warning
rABC58b7c73e214d: [qt] Move BitcoinGUI initializers to class, fix initializer order warning

Summary

C++11-ize the code (move initializers to class, change 0 to nullptr where appropriate)

Backport of Core PR 13528

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Oct 22 2018, 21:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2018, 21:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3662: Diff 5507.Oct 22 2018, 21:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Oct 22 2018, 23:11

This revision is now accepted and ready to land.Oct 22 2018, 23:11

Closed by commit rABC58b7c73e214d: [qt] Move BitcoinGUI initializers to class, fix initializer order warning (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by schancel). · Explain WhyOct 24 2018, 18:56

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D1979: [qt] Multiwallet support for GUI (Core PR12610).Dec 28 2018, 22:10

nakihito mentioned this in D4254: ui: Support wallets unloaded dynamically.Oct 15 2019, 02:55

jasonbcox mentioned this in D4568: Merge #15149: gui: Show current wallet name in window title.Nov 27 2019, 21:52

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.h

88 lines

bitcoingui.cpp

16 lines

Diff 5528

View Options

src/qt/bitcoingui.h