Page MenuHomePhabricator

[avalanche] Remove invalidated transactions from the mempool
ClosedPublic

Authored by Fabien on Sep 4 2025, 21:18.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2ac846dd7283: [avalanche] Remove invalidated transactions from the mempool
Summary

It is possible for a transaction the be invalidated when in the mempool: if 2 conflicting transactions are both rejected one of them is lastly pulled back to mempool where invalidation can happen. We need to make sure we remove such a tx from the mempool and not assume it's already been removed.

To do so we simply apply the same logic to rejection and invalidation, with the additional steps for invalidation.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_remove_invalid_from_mempool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34336
Build 68140: Build Difflint-circular-dependencies · build-diff · build-clang-tidy · build-debug · build-without-wallet · build-clang
Build 68139: arc lint + arc unit