Page MenuHomePhabricator
Differential D18846

[ecash-agora] Patch CI tests by better organizing test wallet sats
ClosedPublic
Actions

Authored by bytesofman on Tue, Oct 28, 20:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC37224c487625: [ecash-agora] Patch CI tests by better organizing test wallet sats
Summary

Not sure how this got past CI initially but starting to see some sats-related failures in CI that I cannot repeat locally.

Use separate methods to fund the separate wallets so it is more clear what is going on. More sats for the taker wallet.

Test Plan

npm test, CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch-agora-tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34895
Build 69252: Build Diffecash-agora-tests · cashtab-tests · ecash-agora-integration-tests
Build 69251: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Oct 28, 20:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Oct 28, 20:54
Harbormaster completed remote builds in B34895: Diff 56341.Tue, Oct 28, 21:01
bytesofman published this revision for review.Tue, Oct 28, 21:02
bytesofman mentioned this in D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.
bytesofman added a child revision: D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.Tue, Oct 28, 21:54
bytesofman added a child revision: D18845: [ecash-agora] take method only supports taking by the taking wallet.Tue, Oct 28, 21:58
bytesofman added a child revision: D18847: [ecash-agora] Support for ALP relist.Wed, Oct 29, 02:45
Fabien accepted this revision.Wed, Oct 29, 10:27
This revision is now accepted and ready to land.Wed, Oct 29, 10:27
Closed by commit rABC37224c487625: [ecash-agora] Patch CI tests by better organizing test wallet sats (authored by bytesofman). · Explain WhyWed, Oct 29, 12:32
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC37224c487625: [ecash-agora] Patch CI tests by better organizing test wallet sats.
bytesofman removed a child revision: D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.Wed, Oct 29, 16:08
bytesofman removed a child revision: D18847: [ecash-agora] Support for ALP relist.

Revision Contents
Changeset List

PathSize
modules/
ecash-agora/
4 lines
4 lines
2 lines
tests/
9 lines
10 lines

Diff 56341

View Options

modules/ecash-agora/README.md

Loading...
View Options

modules/ecash-agora/package-lock.json

Loading...
View Options

modules/ecash-agora/package.json

Loading...
View Options

modules/ecash-agora/tests/partial.alp.test.ts

Loading...
View Options

modules/ecash-agora/tests/partial.slp.test.ts

Loading...