Page MenuHomePhabricator

Cleanup Shibusawa activation after the November 15, 2025 upgrade
ClosedPublic

Authored by Fabien on Fri, Nov 21, 14:05.

Details

Summary

Remove the now unneeded activation code and run the tests against the next upgrade.

Depends on D18955.

Test Plan
ninja all check check-extended check-upgrade-activated-extended

Run the integration tests for chronik-client

Event Timeline

Tail of the build log:

/work/src/test/util_threadnames_tests.cpp(21): Test suite "util_threadnames_tests" is skipped because disabled
/work/src/test/validation_block_tests.cpp(49): Test suite "validation_block_tests" is skipped because disabled
/work/src/test/validation_chainstate_tests.cpp(22): Test suite "validation_chainstate_tests" is skipped because disabled
/work/src/test/validation_chainstatemanager_tests.cpp(33): Test suite "validation_chainstatemanager_tests" is skipped because disabled
/work/src/test/validation_flush_tests.cpp(13): Test suite "validation_flush_tests" is skipped because disabled
/work/src/test/validation_tests.cpp(34): Test suite "validation_tests" is skipped because disabled
/work/src/test/validationinterface_tests.cpp(17): Test suite "validationinterface_tests" is skipped because disabled
/work/src/test/xoroshiro128plusplus_tests.cpp(10): Test suite "xoroshiro128plusplus_tests" is skipped because disabled
/work/src/test/blockindex_comparator_tests.cpp(9): Test suite "blockindex_comparator_tests" is skipped because disabled
/work/src/rpc/test/server_tests.cpp(14): Test suite "server_tests" is skipped because disabled
/work/src/wallet/test/db_tests.cpp(17): Test suite "db_tests" is skipped because disabled
/work/src/wallet/test/coinselector_tests.cpp(23): Test suite "coinselector_tests" is skipped because disabled
/work/src/wallet/test/init_tests.cpp(14): Test suite "init_tests" is skipped because disabled
/work/src/wallet/test/ismine_tests.cpp(18): Test suite "ismine_tests" is skipped because disabled
/work/src/wallet/test/psbt_wallet_tests.cpp(16): Test suite "psbt_wallet_tests" is skipped because disabled
/work/src/wallet/test/scriptpubkeyman_tests.cpp(14): Test suite "scriptpubkeyman_tests" is skipped because disabled
/work/src/wallet/test/wallet_tests.cpp(39): Test suite "wallet_tests" is skipped because disabled
/work/src/wallet/test/walletdb_tests.cpp(31): Test suite "walletdb_tests" is skipped because disabled
/work/src/wallet/test/wallet_crypto_tests.cpp(15): Entering test suite "wallet_crypto_tests"
/work/src/wallet/test/wallet_crypto_tests.cpp(98): Entering test case "passphrase"
test_bitcoin: /work/src/test/util/setup_common.cpp:113: BasicTestingSetup::BasicTestingSetup(ChainType, const std::vector<const char*>&): Assertion `success' failed.
Aborted (core dumped)
[736/909] Running bitcoin test suite
PASSED: bitcoin test suite
[750/909] Running seeder test suite
PASSED: seeder test suite
[754/909] Running pow test suite
PASSED: pow test suite
[757/909] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[781/909] Running avalanche test suite
PASSED: avalanche test suite
[782/909] Running functional tests with the next upgrade activated
Starting Bitcoin ABC functional tests with the next upgrade activated
Temporary test directory at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20251121_141704_24050
...........
----------------------------------------------------------------------
Ran 11 tests in 0.062s

OK
usage: create_cache.py [options]
create_cache.py: error: unrecognized arguments: --with-shibusawaactivation
Running Unit Tests for Test Framework Modules
Traceback (most recent call last):
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 1107, in <module>
    main()
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 478, in main
    run_tests(
  File "/work/abc-ci-builds/build-diff/test/./functional/test_runner.py", line 561, in run_tests
    subprocess.check_output(
  File "/usr/lib/python3.11/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/work/test/functional/create_cache.py', '--cachedir=/work/abc-ci-builds/build-diff/test/cache', '--with-shibusawaactivation', '--configfile=/work/abc-ci-builds/build-diff/test/functional/../config.ini', '--tmpdir=/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20251121_141704_24050/cache']' returned non-zero exit status 2.
FAILED: test/CMakeFiles/check-functional-upgrade-activated /work/abc-ci-builds/build-diff/test/CMakeFiles/check-functional-upgrade-activated 
cd /work/abc-ci-builds/build-diff/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-diff/test/log && /usr/bin/cmake -E env /usr/bin/python3 ./functional/test_runner.py "--testsuitename=Bitcoin ABC functional tests with the next upgrade activated" --junitoutput=/work/abc-ci-builds/build-diff/test/junit/functional_tests_with_the_next_upgrade_activated.xml --with-shibusawaactivation
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

I missed the cmake files

@bot build-master chronik-client-integration-tests

Fabien published this revision for review.Fri, Nov 21, 16:30
This revision is now accepted and ready to land.Sat, Nov 22, 08:55