Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3f1751925f6b: [qa] fix pad_tx to better match the desired size
rABC3f1751925f6b: [qa] fix pad_tx to better match the desired size

Summary

Currently, pad_tx overpads quite often. This diff makes it pad the
correct amount except in specific cases. This enables us to simplify
some other tests which need to pad blocks.

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Nov 19 2018, 07:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 07:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a subscriber: jasonbcox.Nov 19 2018, 07:29

jasonbcox added inline comments.

test/functional/test_framework/txtools.py
53 ↗	(On Diff #5926)	remove
55 ↗	(On Diff #5926)	Rebase

Rebase fix comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox requested changes to this revision.Nov 19 2018, 07:32

jasonbcox added inline comments.

test/functional/test_framework/txtools.py
27 ↗	(On Diff #5926)	Does this deserve it's own assert before the loop? This way, we can provide a useful error message if the caller manages to build such a tx
28 ↗	(On Diff #5926)	These comments should refer to pad_to_size, not MAX_TX_SIZE

This revision now requires changes to proceed.Nov 19 2018, 07:32

jasonbcox added inline comments.Nov 19 2018, 07:33

test/functional/test_framework/txtools.py
44 ↗	(On Diff #5927)	temp variable for `required_padding - padding_len - extra_bytes`

jasonbcox added inline comments.Nov 19 2018, 07:35

test/functional/test_framework/txtools.py
35 ↗	(On Diff #5927)	padding_len is always equal to required_padding at this line. remove this line and make the next line: `padding_len = min(required_padding, MAX_TXOUT_PUBKEY_SCRIPT - extra_bytes)`