Page MenuHomePhabricator

Fix block construction in abc-p2p-compactblocks.py
ClosedPublic

Authored by deadalnix on Mon, Nov 19, 16:20.

Details

Summary

Because of padding, the code generation a block may have trouble ensuring the block size is the right one. Update such code to take advantage of functionallities added in pad_tx in D2098 to ensure the size is correct.

Depends on D2098, D2103

Test Plan
./test/functional/test_runner.py abc-p2p-compactblock.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Mon, Nov 19, 16:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 19, 16:20
deadalnix updated this revision to Diff 5945.Mon, Nov 19, 16:22

Revert inadvertant change

jasonbcox accepted this revision.Mon, Nov 19, 16:23
This revision is now accepted and ready to land.Mon, Nov 19, 16:23
This revision was automatically updated to reflect the committed changes.