Fix block construction in abc-p2p-compactblocks.py
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2018, 16:20.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py
rABC05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py

Summary

Because of padding, the code generation a block may have trouble ensuring the block size is the right one. Update such code to take advantage of functionallities added in pad_tx in D2098 to ensure the size is correct.

Depends on D2098, D2103

Test Plan

./test/functional/test_runner.py abc-p2p-compactblock.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 19 2018, 16:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 16:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Revert inadvertant change

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Nov 19 2018, 16:23

This revision is now accepted and ready to land.Nov 19 2018, 16:23

Closed by commit rABC05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py (authored by deadalnix). · Explain WhyNov 19 2018, 16:26

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4000: Diff 5944.Nov 19 2018, 16:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4001: Diff 5945.Nov 19 2018, 16:32

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-p2p-compactblocks.py

30 lines

Diff 5947

View Options

test/functional/abc-p2p-compactblocks.py

Fix block construction in abc-p2p-compactblocks.pyClosedPublicActions