Page MenuHomePhabricator
Differential D2104

Fix block construction in abc-p2p-compactblocks.py
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2018, 16:20.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py
rABC05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py
Summary

Because of padding, the code generation a block may have trouble ensuring the block size is the right one. Update such code to take advantage of functionallities added in pad_tx in D2098 to ensure the size is correct.

Depends on D2098, D2103

Test Plan
./test/functional/test_runner.py abc-p2p-compactblock.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
redoabccompactblocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4001
Build 6074: Bitcoin ABC Buildbot (legacy)
Build 6073: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2018, 16:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 16:20
teamcity added a subscriber: teamcity.Nov 19 2018, 16:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 5945.Nov 19 2018, 16:22

Revert inadvertant change

teamcity added a comment.Nov 19 2018, 16:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Nov 19 2018, 16:23
This revision is now accepted and ready to land.Nov 19 2018, 16:23
Closed by commit rABC05e5edb9bfce: Fix block construction in abc-p2p-compactblocks.py (authored by deadalnix). · Explain WhyNov 19 2018, 16:26
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 19 2018, 16:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4000: Diff 5944.Nov 19 2018, 16:29
teamcity added a comment.Nov 19 2018, 16:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4001: Diff 5945.Nov 19 2018, 16:32

Revision Contents
Changeset List

PathSize
test/
functional/
30 lines

Diff 5945

View Options

test/functional/abc-p2p-compactblocks.py

Loading...