Page MenuHomePhabricator
Differential D2134

Nits in src/qt/init.cpp
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2018, 23:32.

Details

Reviewers
Fabien
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGa9325353e2b7: Nits in src/qt/init.cpp
rABCa9325353e2b7: Nits in src/qt/init.cpp
Summary

Fix control flow and stylistic nits in qt/init.cpp

Test Plan
make VERBOSE=1 check

Launch the QT GUI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nits (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4120
Build 6311: Bitcoin ABC Buildbot (legacy)
Build 6310: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 25 2018, 23:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2018, 23:32
teamcity added a subscriber: teamcity.Nov 25 2018, 23:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 25 2018, 23:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4120: Diff 6099.Nov 25 2018, 23:43
Fabien accepted this revision.Nov 26 2018, 15:11
This revision is now accepted and ready to land.Nov 26 2018, 15:11
deadalnix commandeered this revision.Jan 4 2019, 19:05
deadalnix added a reviewer: schancel.
deadalnix updated this revision to Diff 6506.Jan 4 2019, 19:05

Rebase and remove dependency

deadalnix edited the summary of this revision. (Show Details)Jan 4 2019, 19:06
deadalnix removed a parent revision: D2133: Move shared qt/bitcoind initialization steps to shared functions..
teamcity added a comment.Jan 4 2019, 19:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Closed by commit rABCa9325353e2b7: Nits in src/qt/init.cpp (authored by schancel, committed by deadalnix). · Explain WhyJan 4 2019, 19:09
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Jan 4 2019, 19:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4413: Diff 6506.Jan 4 2019, 19:17
PiRK mentioned this in D7889: wallet: Recognize -disablewallet option early.Oct 12 2020, 16:17

Revision Contents
Changeset List

PathSize
src/
qt/
152 lines

Diff 6099

View Options

src/qt/bitcoin.cpp

Loading...