Page MenuHomePhabricator
Differential D2055

Do not pull from Core repos when using gitian-build.sh
ClosedPublic
Actions

Authored by jasonbcox on Nov 13 2018, 00:20.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGe8b8dc1b128b: Do not pull from Core repos when using gitian-build.sh
rABCe8b8dc1b128b: Do not pull from Core repos when using gitian-build.sh
Summary

Minor security risk pulling from untrusted sources.

Depends on D2052

Test Plan

None for now. This script needs more fixing before it works with our release process.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2055
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4147
Build 6365: Bitcoin ABC Buildbot (legacy)
Build 6364: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 13 2018, 00:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2018, 00:20
teamcity added a subscriber: teamcity.Nov 13 2018, 00:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Nov 13 2018, 00:25
jasonbcox added a parent revision: D2052: Revert "Cleanup unused contrib scripts".
teamcity added a comment.Nov 13 2018, 00:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3873: Diff 5783.Nov 13 2018, 00:31
deadalnix accepted this revision.Nov 14 2018, 13:04
This revision is now accepted and ready to land.Nov 14 2018, 13:04
jasonbcox updated this revision to Diff 6136.Nov 27 2018, 18:18

Rebase

teamcity added a comment.Nov 27 2018, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 27 2018, 18:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4147: Diff 6136.Nov 27 2018, 18:26
Closed by commit rABCe8b8dc1b128b: Do not pull from Core repos when using gitian-build.sh (authored by jasonbcox). · Explain WhyNov 27 2018, 19:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
gitian/
12 lines

Diff 6136

View Options

contrib/gitian/gitian-build.sh

Loading...